HBASE-28850 Only return from ReplicationSink.replicationEntries while…

[Apache9]

… all background tasks are finished

[apurtell]

The trade off is this may change the performance of replicateEntries. Before, the replicateEntries call will fail fast at the first failure. After, the replicateEntries will block for the entire time it takes to confirm all local edits in the batch are applied or failed.

I have a testbed where I reproduced SEGV crashes for HBASE-28584. Let me apply this patch there and try it out.

[virajjasani]

Logging the exception before it is suppressed might be helpful? (unless suppressed exceptions are all logged with original exception, which i don't recall if it happens)

[Apache9]

  public static void main(String[] args) {
    Exception error = new Exception("root");
    error.addSuppressed(new IOException("suppressed1"));
    error.addSuppressed(new IOException("suppressed2"));
    error.printStackTrace();
  }

The output

java.lang.Exception: root
	at org.apache.hadoop.hbase.regionserver.regionreplication.RegionReplicationSink.main(RegionReplicationSink.java:461)
	Suppressed: java.io.IOException: suppressed1
		at org.apache.hadoop.hbase.regionserver.regionreplication.RegionReplicationSink.main(RegionReplicationSink.java:462)
	Suppressed: java.io.IOException: suppressed2
		at org.apache.hadoop.hbase.regionserver.regionreplication.RegionReplicationSink.main(RegionReplicationSink.java:463)

So I think it is fine to not log it here?

[virajjasani]

Just a minor comment above, +1 otherwise. Had an offline chat with @apurtell also reg this!

[apurtell]

The change looks good. I rehydrated the testbed where I was able to reproduce SEGVs and everything has been stable and performing normally after 250M rows replicated on the way up to 1B. Not expecting any issues.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	2m 53s		master passed
+1 💚	compile	3m 2s		master passed
+1 💚	checkstyle	0m 34s		master passed
+1 💚	spotbugs	1m 30s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 48s		the patch passed
+1 💚	compile	3m 28s		the patch passed
+1 💚	javac	3m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 45s		the patch passed
+1 💚	spotbugs	1m 53s		the patch passed
+1 💚	hadoopcheck	11m 59s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 9s		The patch does not generate ASF License warnings.
		38m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6263/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6263
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux d903d5c341b7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / adc9fcc
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6263/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 6s		master passed
+1 💚	compile	0m 58s		master passed
+1 💚	javadoc	0m 30s		master passed
+1 💚	shadedjars	5m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 56s		the patch passed
+1 💚	compile	0m 58s		the patch passed
+1 💚	javac	0m 58s		the patch passed
+1 💚	javadoc	0m 30s		the patch passed
+1 💚	shadedjars	5m 16s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	237m 30s		hbase-server in the patch passed.
		261m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6263/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6263
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 2e2396adbb2b 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / adc9fcc
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6263/2/testReport/
Max. process+thread count	4637 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6263/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.