[#6116] fix(authz): Fix the check of duplicated privileges #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
reviewed
Jan 6, 2025
| Lists.newArrayList(Privileges.SelectTable.allow(), Privileges.SelectTable.deny()))); | ||
| Lists.newArrayList(Privileges.ReadFileset.allow(), Privileges.ReadFileset.deny()))); |
There was a problem hiding this comment.
I think maybe we can use Set<Privilge> in the grantPrivilegesToRole(..., ..., Set<Privilge> privileges) ?
There was a problem hiding this comment.
I modified the implement of server. If we want to change the client side, we should deprecate the API and add new API.
xunliu
reviewed
Jan 7, 2025
| @@ -321,7 +322,7 @@ static SecurableObjectDTO toSecurableObject(SecurableObject securableObject) { | |||
| .build(); | |||
| } | |||
|
|
|||
| static List<PrivilegeDTO> toPrivileges(List<Privilege> privileges) { | |||
| static List<PrivilegeDTO> toPrivileges(Collection<Privilege> privileges) { | |||
There was a problem hiding this comment.
Collection<Privilege> or Set<Privilege>?
There was a problem hiding this comment.
Collection. Other places I used some collections which are not sets.
jerqi
added
branch-0.8
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 9, 2025
…che#6117) ### What changes were proposed in this pull request? Fix the check of duplicated privileges ### Why are the changes needed? Fix: apache#6116 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added new UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the check of duplicated privileges
Why are the changes needed?
Fix: #6116
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new UT.