[#3526] feat(trino-connector): Support create Gravitino catalog by using Trino CREATE CATALOG command #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Support create gravitino catalog by CREATE CATALOG statement
|
Could you please add a commit to enable the tests first? |
yuqi1129
reviewed
May 27, 2024
.../src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogConnectorManager.java
Outdated
Show resolved
Hide resolved
| @@ -420,4 +421,26 @@ public void addMetalake(String metalake) { | |||
| public Set<String> getUsedMetalakes() { | |||
| return usedMetalakes; | |||
| } | |||
|
|
|||
| public Connector createConnector( | |||
| String connectorName, GravitinoConfig config, ConnectorContext context) { | |||
There was a problem hiding this comment.
context has not been used, do you have other consideration that make it as a parameter?
There was a problem hiding this comment.
I will be used by next pr
| @@ -13,6 +13,8 @@ | |||
| public class GravitinoConfig { | |||
|
|
|||
| public static String GRAVITINO_DYNAMIC_CONNECTOR = "__gravitino.dynamic.connector"; | |||
| public static String GRAVITINO_DYNAMIC_CONNECTOR_CATALOG_CONFIG = | |||
| "__gravitino.dynamic.connector.catalog.config"; | |||
There was a problem hiding this comment.
Is the value of this key set automatically determined by Trino?
| GravitinoTable table = metadataAdapter.createTable(tableMetadata); | ||
| catalogConnectorMetadata.createTable(table); | ||
| catalogConnectorMetadata.createTable(table, saveMode == SaveMode.IGNORE); |
There was a problem hiding this comment.
What's the meaning of SaveMode.IGNORE?
There was a problem hiding this comment.
saveMode == SaveMode.IGNORE it means create table if not exist
| @@ -22,7 +23,10 @@ default List<PropertyMetadata<?>> getTableProperties() { | |||
| } | |||
|
|
|||
| /** @return Return internal connector config with Trino. */ | |||
| Map<String, Object> buildInternalConnectorConfig(GravitinoCatalog catalog) throws Exception; | |||
| Map<String, String> buildInternalConnectorConfig(GravitinoCatalog catalog) throws Exception; | |||
There was a problem hiding this comment.
Is this change a result of the interfaced modification introduced by Trino 435?
There was a problem hiding this comment.
It's modified by a newly created connector mechanism.
mchades
reviewed
May 27, 2024
| import org.junit.jupiter.api.MethodOrderer; | ||
| import org.junit.jupiter.api.Order; | ||
| import org.junit.jupiter.api.Tag; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.TestMethodOrder; | ||
| import org.openqa.selenium.By; | ||
|
|
||
| @Disabled |
There was a problem hiding this comment.
The CatalogPageTest shouldn't rely on Trino, Can you decouple them?
There was a problem hiding this comment.
It's Depend on the Trino docker environment
There was a problem hiding this comment.
But it doesn't use Trino, right?
trino-connector/src/main/java/com/datastrato/gravitino/trino/connector/GravitinoConfig.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
May 27, 2024
...rc/main/java/com/datastrato/gravitino/trino/connector/catalog/hive/HiveConnectorAdapter.java
Outdated
Show resolved
Hide resolved
|
I'm okay with the current changes. |
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
May 30, 2024
… by using Trino CREATE CATALOG command (apache#3540) 1. Upgrade code to Trino-435 2. Support create Gravitino catalog by CREATE CATALOG statement 3. Disable testers of Trino Connector Fix: apache#3526 NO Exists UT
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
May 30, 2024
… by using Trino CREATE CATALOG command (apache#3540) 1. Upgrade code to Trino-435 2. Support create Gravitino catalog by CREATE CATALOG statement 3. Disable testers of Trino Connector Fix: apache#3526 NO Exists UT
jerryshao
pushed a commit
that referenced
this pull request
May 31, 2024
jerryshao
pushed a commit
that referenced
this pull request
May 31, 2024
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
… by using Trino CREATE CATALOG command (apache#3540) 1. Upgrade code to Trino-435 2. Support create Gravitino catalog by CREATE CATALOG statement 3. Disable testers of Trino Connector Fix: apache#3526 NO Exists UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #3526
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Exists UT