[#168] feat(core): Refactor the ID field of entity to assign a unique id for this field

[jerryshao]

What changes were proposed in this pull request?

This PR proposes to make some changes to entity's ID field.

1. Assign a unique ID for each entity when creating.
2. Remove the parent ID field for catalog, schema and table entity (since it is useless currently).

Why are the changes needed?

This is the subtask for #250 . With unique ID assigned to each entity, we could leverage this unique ID as a "record" or "watermark" to be bound between the underlying sources and graviton store, which can guarantee the SSOT of entities.

Fix: #168

Does this PR introduce any user-facing change?

1. This change removes the parent id field of catalog, schema, and table entity's proto definition.

How was this patch tested?

With the existing UTs.

[github-actions]

Code Coverage Report

Overall Project	63.38% -0.23%	🟢
Files changed	71.79%	🟢

Module	Coverage
core	71.46% -0.72%	🟢
catalog-hive	58.82%	🟢

Files

Module	File	Coverage
core	HasIdentifier.java	100%	🟢
	SchemaEntitySerDe.java	100%	🟢
	TableEntitySerde.java	100%	🟢
	Entity.java	96.94%	🟢
	BaseMetalakeSerDe.java	90.83%	🟢
	CatalogEntitySerDe.java	85.71%	🟢
	BaseTable.java	80.81%	🟢
	BaseSchema.java	79.78%	🟢
	BaseMetalake.java	79.4%	🟢
	MetalakeManager.java	78.16% -1.44%	🟢
	CatalogEntity.java	73.56% -11.53%	🔴
	CatalogManager.java	61.99%	🟢
	GravitonEnv.java	0% -22.31%	🔴
catalog-hive	HiveTable.java	94.4%	🟢
	HiveSchema.java	83.95%	🟢
	HiveCatalogOperations.java	66.07%	🟢

[yuqi1129]

Got it

…

2023年9月7日 15:21，Jerry Shao ***@***.***> 写道： @jerryshao commented on this pull request. In core/src/main/java/com/datastrato/graviton/HasIdentifier.java <#348 (comment)>: > @@ -14,6 +14,13 @@ public interface HasIdentifier { */ String name(); + /** + * Get the unique id of the entity. + * + * @return The unique id of the entity. + */ + Long id(); Using Java object rather than primitive type is that I want this ID Field to be checkable. — Reply to this email directly, view it on GitHub <#348 (comment)>, or unsubscribe </~https://github.com/notifications/unsubscribe-auth/ADYQDBCMXOXD5MWTRRCNXDTXZFYXXANCNFSM6AAAAAA4OH366Q>. You are receiving this because your review was requested.

[yuqi1129]

LGTM