Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1311] bugfix(docker): Unable to run datastrato/trino Docker in AWS #1315

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 3, 2024

What changes were proposed in this pull request?

Trino loss node.id configuration in the node.properties file.

root@ip-172-31-6-157:/# /usr/lib/trino/bin/run-trino
+ launcher_opts=(--etc-dir /etc/trino)
+ grep -s -q node.id /etc/trino/node.properties
+ launcher_opts+=("-Dnode.id=${HOSTNAME}")
+ exec /usr/lib/trino/bin/launcher run --etc-dir /etc/trino -Dnode.id=ip-172-31-6-157.ec2.internal
OpenJDK 64-Bit Server VM warning: Option UseBiasedLocking was deprecated in version 15.0 and will likely be removed in a future release.
Jan 02, 2024 2:33:42 PM io.airlift.log.Logger info
INFO: Java version: 17.0.8.1
2024-01-02T14:33:42.382Z	INFO	main	io.airlift.log.Logging	Logging to stderr
2024-01-02T14:33:42.383Z	INFO	main	Bootstrap	Loading configuration
2024-01-02T14:33:42.645Z	INFO	main	org.hibernate.validator.internal.util.Version	HV000001: Hibernate Validator 8.0.0.Final
2024-01-02T14:33:43.052Z	INFO	main	Bootstrap	Initializing logging
2024-01-02T14:33:46.142Z	ERROR	main	io.trino.server.Server	Configuration is invalid
==========
Errors:
1) Invalid configuration property node.id: is malformed (for class io.airlift.node.NodeConfig.nodeId)
==========

Why are the changes needed?

Fix: #1311

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Manually test in the AWS

…1312)

### What changes were proposed in this pull request?

Trino loss `node.id` configuration in the `node.properties` file.

```
root@ip-172-31-6-157:/# /usr/lib/trino/bin/run-trino
+ launcher_opts=(--etc-dir /etc/trino)
+ grep -s -q node.id /etc/trino/node.properties
+ launcher_opts+=("-Dnode.id=${HOSTNAME}")
+ exec /usr/lib/trino/bin/launcher run --etc-dir /etc/trino -Dnode.id=ip-172-31-6-157.ec2.internal
OpenJDK 64-Bit Server VM warning: Option UseBiasedLocking was deprecated in version 15.0 and will likely be removed in a future release.
Jan 02, 2024 2:33:42 PM io.airlift.log.Logger info
INFO: Java version: 17.0.8.1
2024-01-02T14:33:42.382Z	INFO	main	io.airlift.log.Logging	Logging to stderr
2024-01-02T14:33:42.383Z	INFO	main	Bootstrap	Loading configuration
2024-01-02T14:33:42.645Z	INFO	main	org.hibernate.validator.internal.util.Version	HV000001: Hibernate Validator 8.0.0.Final
2024-01-02T14:33:43.052Z	INFO	main	Bootstrap	Initializing logging
2024-01-02T14:33:46.142Z	ERROR	main	io.trino.server.Server	Configuration is invalid
==========
Errors:
1) Invalid configuration property node.id: is malformed (for class io.airlift.node.NodeConfig.nodeId)
==========
```

### Why are the changes needed?

Fix: #1311

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Manually test in the AWS
@github-actions github-actions bot added cherry-pick need backport Issues that need to backport to another branch labels Jan 3, 2024
@github-actions github-actions bot requested a review from jerryshao January 3, 2024 13:45
@jerryshao jerryshao closed this Jan 3, 2024
@jerryshao jerryshao reopened this Jan 3, 2024
Copy link
Author

github-actions bot commented Jan 3, 2024

Code Coverage Report

Overall Project 66.02% 🟢

There is no coverage information present for the Files changed

@jerryshao jerryshao merged commit 31d1481 into branch-0.3 Jan 3, 2024
4 checks passed
@jerryshao jerryshao deleted the cherry-pick-branch-0.3-84679e96ec870bd584e4f718709033ad4c44b664 branch January 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants