Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] Remove MANAGED_BY_GRAVITINO limit #5336

Closed
Tracked by #5115
xunliu opened this issue Oct 29, 2024 · 0 comments · Fixed by #5629
Closed
Tracked by #5115

[Subtask] Remove MANAGED_BY_GRAVITINO limit #5336

xunliu opened this issue Oct 29, 2024 · 0 comments · Fixed by #5629
Assignees
Labels
subtask Subtasks of umbrella issue

Comments

@xunliu
Copy link
Member

xunliu commented Oct 29, 2024

Describe the subtask

Currently, Gravitino only operation have MANAGED_BY_GRAVITINO label's Ranger Policy.
If a user has a Ranger service and this Ranger already has some Ranger Policy.
When Gravitino will push down a Ranger Policy, if this Policy manage resource already exist in the Ranger service and this Policy doesn't have MANAGED_BY_GRAVITINO label, then Gravitino will throw exception.

Parent issue

#5115

@xunliu xunliu added the subtask Subtasks of umbrella issue label Oct 29, 2024
@xunliu xunliu self-assigned this Oct 29, 2024
xunliu added a commit to xunliu/gravitino that referenced this issue Oct 29, 2024
@xunliu xunliu changed the title [Subtask] Remove MANAGED_BY_GRAVITINO limite [Subtask] Remove MANAGED_BY_GRAVITINO limit Oct 29, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 20, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 20, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 20, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 21, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 21, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 21, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 21, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 22, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 25, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 25, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 25, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 26, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 26, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 26, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 27, 2024
theoryxu pushed a commit to theoryxu/gravitino that referenced this issue Nov 27, 2024
xunliu pushed a commit that referenced this issue Nov 27, 2024
…atible for existing ranger policy (#5629)

### What changes were proposed in this pull request?

Many clients and users have used Ranger for a while. Gravitino should be
compatible with these cases.

There are some principles Gravitino needs to follow when it pushes down
policies:

1. Gravitino can't modify existing policy names because users may have
their own name rules.
2. Gravitino and users could share the same policy and not disturb each
other for the same resource.

For the target, this PR includes the following changes:

1. `wildcardSearchPolies` removes the `MANAGED_BY_GRAVITINO` filter.
2. Gravitino managed role name add the prefix `GRAVITINO_`.
3. Using Gravitino Managed role to identify and operate policy items.

Despite doing these, users should be cautious about directly managing
the ranger policy. There are some restricts:

1. Don't directly rename Gravitino-managed policies.
2. Don't directly modify policy resources in the policy that have
Gravitino Managed roles.
3. Don't directly modify policy items that have Gravitino Managed roles.

### Why are the changes needed?

Fix: #5336

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Added ITs

---------

Co-authored-by: theoryxu <theoryxu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subtask Subtasks of umbrella issue
Projects
None yet
1 participant