[Bug report] User can delete the gravitino id properity in the Gravitino Web UI #1397
Labels
good first issue
Good for newcomers
Comments
jerryshao
pushed a commit
that referenced
this issue
Jan 9, 2024
### What changes were proposed in this pull request? Fix update metalake error in the web UI. The reason for the error is that the existing metalake is not set with `properties`, causing an error unable to find properties when deconstructing the `properties` of metalake. The solution is to set an empty object to the `properties`. 1. existed metalake without `properties` <img width="389" alt="no-props" src="/~https://github.com/datastrato/gravitino/assets/17310559/42478741-3163-49c8-8ac5-54116abcc035"> 2. click `update metalake` icon button, and now the update pop-up will display correctly. <img width="596" alt="update-metalake" src="/~https://github.com/datastrato/gravitino/assets/17310559/7fc99516-abb9-4412-a032-326765357023"> ### Why are the changes needed? Fix: #1391 Fix: #1397 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
github-actions bot
pushed a commit
that referenced
this issue
Jan 9, 2024
### What changes were proposed in this pull request? Fix update metalake error in the web UI. The reason for the error is that the existing metalake is not set with `properties`, causing an error unable to find properties when deconstructing the `properties` of metalake. The solution is to set an empty object to the `properties`. 1. existed metalake without `properties` <img width="389" alt="no-props" src="/~https://github.com/datastrato/gravitino/assets/17310559/42478741-3163-49c8-8ac5-54116abcc035"> 2. click `update metalake` icon button, and now the update pop-up will display correctly. <img width="596" alt="update-metalake" src="/~https://github.com/datastrato/gravitino/assets/17310559/7fc99516-abb9-4412-a032-326765357023"> ### Why are the changes needed? Fix: #1391 Fix: #1397 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
yuqi1129
pushed a commit
that referenced
this issue
Jan 9, 2024
### What changes were proposed in this pull request? Fix update metalake error in the web UI. The reason for the error is that the existing metalake is not set with `properties`, causing an error unable to find properties when deconstructing the `properties` of metalake. The solution is to set an empty object to the `properties`. 1. existed metalake without `properties` <img width="389" alt="no-props" src="/~https://github.com/datastrato/gravitino/assets/17310559/42478741-3163-49c8-8ac5-54116abcc035"> 2. click `update metalake` icon button, and now the update pop-up will display correctly. <img width="596" alt="update-metalake" src="/~https://github.com/datastrato/gravitino/assets/17310559/7fc99516-abb9-4412-a032-326765357023"> ### Why are the changes needed? Fix: #1391 Fix: #1397 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A Co-authored-by: CHEYNE <contact@ch3yne.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what's wrong
Users can delete the Gravitino id property in the Gravitino Web UI. Perhaps this shouldn't be allowed?
Error message and/or stacktrace
How to reproduce
Edit a metalake in the Gavitino UI and delete the Gravitino id property. Bad things happen.
Additional context
No response
The text was updated successfully, but these errors were encountered: