-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update documents for multiple level drilldown - childGroupId
#295
Conversation
childGroupId
childGroupId
Hi @quillblue @pissang @Ovilia, I have finished both en and zh docs for multiple levels drilldown(apache/echarts#17611), please review the docs when you have time. |
|
||
The group ID of the child data of a data item. This option is introduced to make multiple levels drilldown and aggregation animation possilbe. | ||
|
||
~[700x300](${galleryViewPath}doc-example/bar-drilldown&edit=1&reset=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example will take effect after apache/echarts-examples#55 is finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the new options don't have a version tip, such as childGroupId
and itemChildGroupId
. You can add it like this,
{{ use: partial-version(
version = "5.5.0"
) }}
And the example link might need to be updated to the new bar-multi-drilldown
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I will create another PR to address this :-)
And the example link is not correct, neither. It should be changed to /bar-multi-drilldown
now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
modified: