Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documents for multiple level drilldown - childGroupId #295

Merged
merged 11 commits into from
Oct 29, 2022

Conversation

tyn1998
Copy link
Contributor

@tyn1998 tyn1998 commented Sep 22, 2022

  • Chinese
  • English

modified:

  • series.dataGroupId
  • series.data.groupId
  • series.data.childGroupId (Add)
  • series.encode
  • series.universalTransition

@tyn1998 tyn1998 changed the title WIP: docs: update documents for multiple level drilldown - childGroupId docs: update documents for multiple level drilldown - childGroupId Sep 28, 2022
@tyn1998 tyn1998 marked this pull request as ready for review September 28, 2022 12:54
@tyn1998
Copy link
Contributor Author

tyn1998 commented Sep 28, 2022

Hi @quillblue @pissang @Ovilia,

I have finished both en and zh docs for multiple levels drilldown(apache/echarts#17611), please review the docs when you have time.


The group ID of the child data of a data item. This option is introduced to make multiple levels drilldown and aggregation animation possilbe.

~[700x300](${galleryViewPath}doc-example/bar-drilldown&edit=1&reset=1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example will take effect after apache/echarts-examples#55 is finished.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the new options don't have a version tip, such as childGroupId and itemChildGroupId. You can add it like this,

{{ use: partial-version(
    version = "5.5.0"
) }}

And the example link might need to be updated to the new bar-multi-drilldown.

Copy link
Contributor Author

@tyn1998 tyn1998 Dec 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I will create another PR to address this :-)

And the example link is not correct, neither. It should be changed to /bar-multi-drilldown now.

Copy link

@quillblue quillblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@Ovilia Ovilia changed the base branch from master to next October 29, 2022 14:14
@Ovilia Ovilia changed the base branch from next to master October 29, 2022 14:17
@Ovilia Ovilia changed the base branch from master to next October 29, 2022 14:18
@quillblue quillblue merged commit 6781a9e into apache:next Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants