Temporary fix for CI #13689
Merged
Temporary fix for CI #13689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I filed an upstream ticket (with reproducer): Alexhuszagh/rust-lexical#191 |
|
Thanks again @jonahgao for getting us unblocked |
Alexhuszagh
added a commit
to Alexhuszagh/datafusion
that referenced
this pull request
Dec 8, 2024
Issue was patched as of lexical release 1.0.5. Reverts apache#13689 Closes apache#13686
jonahgao
pushed a commit
that referenced
this pull request
Dec 9, 2024
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 11, 2024
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 11, 2024
Issue was patched as of lexical release 1.0.5. Reverts apache#13689 Closes apache#13686
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 15, 2024
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 15, 2024
Issue was patched as of lexical release 1.0.5. Reverts apache#13689 Closes apache#13686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Temporary fix for #13686
Rationale for this change
Tests panicked in arrow's
pretty_format_batches_with_options, caused by the new release of lexical-write-integer.This PR pins the version of lexical-write-integer and makes cargo choose the common version among DataFusion and arrow-rs to v1.0.2.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No. Only modify dev-dependencies.