Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No panic on timestamp buffer overflow #3519

Merged
merged 2 commits into from
Jan 13, 2023
Merged

No panic on timestamp buffer overflow #3519

merged 2 commits into from
Jan 13, 2023

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #3512.

Rationale for this change

No panic on timestamp buffer overflow, when casting happens for nanoseconds for dates beyond supported by chrono-rs

What changes are included in this PR?

Defensive check added to prevent panic

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 12, 2023
tustvold
tustvold approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to include a test within the cast kernel or something

@comphead
Copy link
Contributor Author

It might be nice to include a test within the cast kernel or something

Thanks @tustvold for your feedback, there is already a test attached to test old date.
/~https://github.com/apache/arrow-rs/pull/3519/files#diff-cd568dd408cf11db340aa0259545de48fca7a0c0ac680bb9ff9a34956bab52b1R864

Please let me know if that is not enought

@tustvold tustvold merged commit 84e0cc1 into apache:master Jan 13, 2023
@ursabot
Copy link

ursabot commented Jan 13, 2023

Benchmark runs are scheduled for baseline = 25a11ba and contender = 84e0cc1. 84e0cc1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

alamb
alamb reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @comphead !

arrow-cast/src/parse.rs
@@ -373,6 +385,9 @@ impl Parser for Time32SecondType {
/// Number of days between 0001-01-01 and 1970-01-01
const EPOCH_DAYS_FROM_CE: i32 = 719_163;

/// Error message if nanosecond conversion request beyond supported interval
const ERR_NANOSECONDS_NOT_SUPPORTED: &str = "The dates that can be represented as nanoseconds have to be between 1677-09-21T00:12:44.0 and 2262-04-11T23:47:16.854775804";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tustvold tustvold mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb left review comments

@tustvold tustvold tustvold approved these changes

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overflow when casting timestamps prior to the epoch
5 participants
@comphead @ursabot @viirya @alamb @tustvold