Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Jens Scheffler to committer role #35522

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Move Jens Scheffler to committer role #35522

merged 1 commit into from
Nov 8, 2023

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Nov 8, 2023

This PR adds the meta data for jscheffl as new committer tu use the self-hosted runners as well makes a small nit on documentation update.

potiuk
potiuk requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be so kind to also add Amogh Rajesh and Pankaj Koti to project.rst ? Due to all the Summit announcement -> vacation things we have not followed all the steps and they are also missing there :)

@jscheffl
Copy link
Contributor Author

jscheffl commented Nov 8, 2023

Would you be so kind to also add Amogh Rajesh and Pankaj Koti to project.rst ? Due to all the Summit announcement -> vacation things we have not followed all the steps and they are also missing there :)

In the RST it was mentioned that the "Step 7" shall be done after Step 6 - setup of self-hosted runners. Are Rajesh and Pankaj also setup on the self-hosted runners already, adding them in the globals.py as well?

@potiuk
Copy link
Member

potiuk commented Nov 8, 2023

Ahh @pankajkoti added himself in separate PR so all good.

@potiuk
Copy link
Member

potiuk commented Nov 8, 2023

In the RST it was mentioned that the "Step 7" shall be done after Step 6 - setup of self-hosted runners. Are Rajesh and Pankaj also setup on the self-hosted runners already, adding them in the globals.py as well?

Yes they are.

@potiuk potiuk merged commit 69281ab into apache:main Nov 8, 2023
60 checks passed
@pankajkoti
Copy link
Member

yes, wished to check that the CI is working fine for me :)

@pankajkoti
Copy link
Member

btw, also @amoghrajesh has a PR for himself: #35520

@potiuk
Copy link
Member

potiuk commented Nov 8, 2023

btw, also @amoghrajesh has a PR for himself: #35520

Yep. Just merged :)

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
@jscheffl @romsharon98
Move Jens Scheffler to committer role (apache#35522)
f9e3a32
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

Assignees
No one assigned
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jscheffl @potiuk @pankajkoti @ephraimbuddy