Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI basic api #15015

Merged
merged 6 commits into from
Mar 25, 2021
Merged

UI basic api #15015

merged 6 commits into from
Mar 25, 2021

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 25, 2021

Adding the basics of API communication in the new UI in AIP-38.

Closes #14797

  • new /interfaces for custom types
  • new /api for default values and react-query hooks
  • added GET for version and pipelines
  • testing of loading and empty states for Pipelines
  • removed App.test.tsx it was testing a 3rd party library more than anything we had built
  • added extra linting for the proper use of react hooks

Testing is a little fragile right now. I will have to improve tests but that would be a separate PR. They are passing for now.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 25, 2021
@ryanahamilton ryanahamilton added the AIP-38 Modern Web Application label Mar 25, 2021
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ryanahamilton ryanahamilton merged commit b1ce429 into apache:master Mar 25, 2021
@ryanahamilton ryanahamilton deleted the ui-basic-api branch March 25, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-38 Modern Web Application area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize/configure API connection
2 participants