This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 67 68 +1
Lines 754 752 -2
Branches 146 149 +3
=====================================
- Hits 754 752 -2
Continue to review full report at Codecov.
|
kristw
force-pushed
the
kristw--translate-ts
branch
from
January 9, 2019 08:20
a542111
to
9f0fcd1
Compare
kristw
force-pushed
the
kristw--translate-ts
branch
from
January 15, 2019 21:40
c229d6d
to
e141317
Compare
kristw
force-pushed
the
kristw--translate-ts
branch
from
January 23, 2019 18:26
2635ffc
to
8027e9b
Compare
williaster
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@@ -15,7 +15,7 @@ install: | |||
- yarn install | |||
|
|||
before_script: | |||
- yarn run build | |||
- yarn build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this shorthand for yarn run build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, yarn xxx
= npm run xxx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
🏠 Internal
@superset-ui/translation
to TypeScript