feat(encodable): implement axis functions for ChannelEncoder #247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 147 148 +1
Lines 1619 1636 +17
Branches 427 434 +7
=====================================
+ Hits 1619 1636 +17
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit b647bab |
| import { ChannelType, ChannelInput } from '../types/Channel'; | ||
| import { PlainObject, Dataset } from '../types/Data'; | ||
| import { ChannelDef } from '../types/ChannelDef'; | ||
| import { Value } from '../types/VegaLite'; |
There was a problem hiding this comment.
Just change the imports order
kristw
changed the title
| } | ||
|
|
||
| hasTitle() { | ||
| return this.config.title !== ''; |
There was a problem hiding this comment.
I can't quite tell from the PR, can title be undefined or null? could do !!this.config.title
There was a problem hiding this comment.
This is CompleteAxisConfig which guarantees title will be string.
|
|
||
| if (typeof values !== 'undefined') { | ||
| return (values as ( | ||
| | number |
There was a problem hiding this comment.
could make a separate type (or re-use the config.values type?)
There was a problem hiding this comment.
updated to use util inferElementTypeFromUnionOfArrayTypes
packages/superset-ui-encodable/test/encoders/ChannelEncoderAxis.test.ts
Outdated
Show resolved
Hide resolved
packages/superset-ui-encodable/test/encoders/ChannelEncoderAxis.test.ts
Outdated
Show resolved
Hide resolved
packages/superset-ui-encodable/test/encoders/ChannelEncoderAxis.test.ts
Outdated
Show resolved
Hide resolved
🏆 Enhancements