This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(connection): disable caching when on an insecure connection #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache-superset#193
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=========================================
Coverage ? 99.91%
=========================================
Files ? 94
Lines ? 1165
Branches ? 281
=========================================
Hits ? 1164
Misses ? 0
Partials ? 1
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit 4c9e253 |
kristw
approved these changes
Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the page is served over an insecure connection, some browsers (Firefox) will disable the
CacheStorage API for security reasons and will throw an error when an attempt is made to use it.
Thus, do not even attempt to use CacheStorage on such connections in the first place.
🐛 Bug Fix
fix #193
🏠 Internal
Contrary to what I suggested in the bug, I had to put the test for the insecure connection into
callApiitself to be able to test it.