This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: allow chart plugin to be unregistered #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
commented
Jun 11, 2019
| @@ -17,17 +17,17 @@ type ValueOrModuleWithValue<T> = T | { default: T }; | |||
|
|
|||
| interface ChartPluginConfig<T extends ChartFormData> { | |||
| metadata: ChartMetadata; | |||
| // use buildQuery for immediate value | |||
| /** Use buildQuery for immediate value. For lazy-loading, use loadBuildQuery. */ | |||
There was a problem hiding this comment.
Change comments to /** */ so they will show up in autocomplete
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 88 88
Lines 1095 1102 +7
Branches 263 264 +1
=====================================
+ Hits 1095 1102 +7
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit 5dc5552 |
williaster
approved these changes
Jun 11, 2019
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
Updates the requirements on [d3-scale](/~https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](/~https://github.com/d3/d3-scale/releases) - [Commits](/~https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
.unregister()function toChartPlugin🏠 Internal