-
Notifications
You must be signed in to change notification settings - Fork 272
feat: Set default for Accept field in header to take application/json #1413
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/CWdgn68K7y2Kcz5NUUKNstKm7zeY |
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
+ Coverage 30.42% 33.67% +3.25%
==========================================
Files 497 499 +2
Lines 10003 12481 +2478
Branches 1689 2241 +552
==========================================
+ Hits 3043 4203 +1160
- Misses 6714 8015 +1301
- Partials 246 263 +17
Continue to review full report at Codecov.
|
… into default-content-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test!
💔 Breaking Changes:
Related to apache/superset#17195, Users would see html render for error instead of error json response. To make sure this doesn't happen we are setting the default headers to
Accept: application/json
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
🏠 Internal