Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Convert translation to typescript #74

Merged
merged 4 commits into from
Jan 23, 2019
Merged

Convert translation to typescript #74

merged 4 commits into from
Jan 23, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Jan 9, 2019

🏆 Enhancements
🏠 Internal

  • Convert @superset-ui/translation to TypeScript

@kristw kristw requested a review from a team as a code owner January 9, 2019 08:12
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          67     68    +1     
  Lines         754    752    -2     
  Branches      146    149    +3     
=====================================
- Hits          754    752    -2
Impacted Files Coverage Δ
packages/superset-ui-translation/src/Translator.ts 100% <100%> (ø)
...s/superset-ui-translation/test/languagePacks/zh.ts 100% <100%> (ø)
...superset-ui-translation/src/TranslatorSingleton.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53824db...8027e9b. Read the comment docs.

@kristw kristw force-pushed the kristw--translate-ts branch from a542111 to 9f0fcd1 Compare January 9, 2019 08:20
@kristw kristw added #code-quality reviewable Ready for review labels Jan 9, 2019
@kristw kristw force-pushed the kristw--translate-ts branch from c229d6d to e141317 Compare January 15, 2019 21:40
@kristw kristw force-pushed the kristw--translate-ts branch from 2635ffc to 8027e9b Compare January 23, 2019 18:26
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -15,7 +15,7 @@ install:
- yarn install

before_script:
- yarn run build
- yarn build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this shorthand for yarn run build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yarn xxx = npm run xxx

@kristw kristw merged commit e8f8430 into master Jan 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--translate-ts branch January 23, 2019 18:45
@kristw kristw added this to the v0.9.0 milestone Feb 1, 2019
kristw added a commit that referenced this pull request Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants