GO-4406: creation date of object type is 0 #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
fat-fellow
reviewed
Nov 19, 2024
| @@ -43,6 +43,9 @@ func (s *service) createObjectType(ctx context.Context, space clientspace.Space, | |||
|
|
|||
| createState := state.NewDocWithUniqueKey("", nil, uniqueKey).(*state.State) | |||
| createState.SetDetails(object) | |||
There was a problem hiding this comment.
DRY - you've repeated the code 3 times
Coverage provided by /~https://github.com/seriousben/go-patch-cover-action |
requilence
requested changes
Nov 26, 2024
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
…o-4406-creation-date-of-object-type-is-0 # Conflicts: # core/block/object/objectcreator/installer.go
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
requilence
approved these changes
Jan 15, 2025
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
AnastasiaShemyakinskaya
deleted the
go-4406-creation-date-of-object-type-is-0
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set original created date of derived objects in case it is provided in details in function
CreateObject