Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4241: The name of the Space member is not displayed #1741

Conversation

AnastasiaShemyakinskaya
Copy link
Member

We initialize title block before SetDetails call, so it is turned out to be empty after participant creation.
So the fix is to call title block creation in template.InitTemplate after SetDetails call

Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Copy link

New Coverage 49.2% of statements
Patch Coverage 90.0% of changed statements (9/10)

Coverage provided by /~https://github.com/seriousben/go-patch-cover-action

@AnastasiaShemyakinskaya AnastasiaShemyakinskaya merged commit c11ec9a into main Oct 29, 2024
5 checks passed
@AnastasiaShemyakinskaya AnastasiaShemyakinskaya deleted the go-4241-the-name-of-the-space-member-is-not-displayed branch October 29, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants