GO-4171: Fix potential race in subscription cache #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage provided by /~https://github.com/seriousben/go-patch-cover-action |
fat-fellow
reviewed
Oct 15, 2024
core/subscription/cache.go
Outdated
| @@ -86,13 +88,18 @@ func (e *entry) Get(key string) *types.Value { | |||
|
|
|||
| type cache struct { | |||
| entries map[string]*entry | |||
| sync.Mutex | |||
There was a problem hiding this comment.
should we use the rwmutex and use readlock for get?
There was a problem hiding this comment.
you could just lock the whole spaceSubscription in collectionObserver.fetchEntries, the 99% of time the cache is accessed in one goroutine, and it's accessed a lot, so constant locking-unlocking will add performance overhead
btw use feature/chat as target branch
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
AnastasiaShemyakinskaya
force-pushed
the
go-4171-fix-potential-race-in-subscription-cache
branch
from
ad7ee9d to
6a957ed
Compare
AnastasiaShemyakinskaya
force-pushed
the
go-4171-fix-potential-race-in-subscription-cache
branch
from
524032f to
d8aabb6
Compare
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
deff7
approved these changes
Oct 17, 2024
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
AnastasiaShemyakinskaya
deleted the
go-4171-fix-potential-race-in-subscription-cache
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/anytype/issue/GO-4171/fix-potential-race-in-subscription-cache