GO-4168 Rollback SetSource #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage provided by /~https://github.com/seriousben/go-patch-cover-action |
deff7
reviewed
Oct 3, 2024
| st := sb.NewStateCtx(ctx) | ||
|
|
||
| // nolint:errcheck | ||
| _ = st.Iterate(func(b simple.Block) (isContinue bool) { |
There was a problem hiding this comment.
encapsulate this in simple/dataview block
There was a problem hiding this comment.
if dv := b.Model().GetDataview(); dv != nil {
for _, view := range dv.Views {
view.DefaultTemplateId = ""
view.DefaultObjectTypeId = ""
}
st.Set(b)
return false
}
There was a problem hiding this comment.
I have implemented separate method in editor.Dataview for setting source in sets
deff7
reviewed
Oct 4, 2024
| view.DefaultTemplateId = "" | ||
| view.DefaultObjectTypeId = "" | ||
| if err = dv.SetView(view.Id, *view); err != nil { | ||
| log.With("objectId", d.Id()).Errorf("failed to update view '%s' of set: %v", view.Id, err) |
There was a problem hiding this comment.
maybe return with error?
btw use log fields for anything except error
deff7
approved these changes
Oct 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/anytype/issue/GO-4168/the-selected-query-is-not-deleted-in-the-set-when-clicking-on-the