GO-4162 corrupted links in markdown import #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Coverage provided by /~https://github.com/seriousben/go-patch-cover-action |
fat-fellow
reviewed
Oct 2, 2024
| assert.Equal(t, model.BlockContentTextMark_Object, block.GetText().GetMarks().GetMarks()[1].Type) | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
сonsider use @deff7's testutil.BuildStateFromAST
There was a problem hiding this comment.
I don't see advantages in using it, because we need just to manipulate text block
deff7
reviewed
Oct 4, 2024
| @@ -89,3 +89,155 @@ func Test_processFiles(t *testing.T) { | |||
| assert.Len(t, fileBlocks, 0) | |||
| }) | |||
| } | |||
|
|
|||
| func Test_processTextBlock(t *testing.T) { | |||
There was a problem hiding this comment.
I suggest using real markdown test data here
testing small internal functions leads to fragile tests and don't cover the whole process of import
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
deff7
requested changes
Oct 8, 2024
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
deff7
reviewed
Oct 9, 2024
| fileNameToObjectId[snapshot.FileName] = snapshot.Id | ||
| } | ||
| var found bool | ||
| expectedPath := "testdata" + string(filepath.Separator) + "links.md" |
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
deff7
approved these changes
Oct 9, 2024
AnastasiaShemyakinskaya
deleted the
go-4162-corrupted-links-in-markdown-import
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/anytype/issue/GO-4162/corrupted-links-in-markdown-import
The problem is that we don't handle cases, when block have more than one markdown besides links. For example link can be also bold or italic.
To fix it