GO-3964 ListRelationsByValue RPC #1552
Conversation
Coverage provided by /~https://github.com/seriousben/go-patch-cover-action |
| @@ -504,3 +504,41 @@ func (s *dsObjectStore) QueryByIDAndSubscribeForChanges(ids []string, sub databa | |||
| s.addSubscriptionIfNotExists(sub) | |||
| return | |||
| } | |||
|
|
|||
| func (s *dsObjectStore) QueryAndProcess(q database.Query, proc func(details *types.Struct)) error { | |||
core/block/relation.go
Outdated
| @@ -56,3 +64,75 @@ func (s *Service) ObjectTypeRemoveRelations(ctx context.Context, objectTypeId st | |||
| return b.Apply(st) | |||
| }) | |||
| } | |||
|
|
|||
| func (s *Service) ListRelationsWithValue(spaceId string, value *types.Value) (keys []string, counters []int64, err error) { | |||
pkg/lib/localstore/addr/addr.go
Outdated
| @@ -48,3 +48,10 @@ func ExtractVirtualSourceType(id string) (model.SmartBlockType, error) { | |||
| func TimeToID(t time.Time) string { | |||
| return DatePrefix + t.Format("2006-01-02") | |||
| } | |||
|
|
|||
| func DateIDToDayStart(id string) (time.Time, error) { | |||
There was a problem hiding this comment.
it shouldn't be here, it's pretty specific case, put it near usage
| } | ||
|
|
||
| func (s *service) partitionObjectIDsBySpaceID(objectIDs []string) (map[string][]string, error) { | ||
| res := map[string][]string{} |
There was a problem hiding this comment.
May be it can be preallocated?
| return fmt.Errorf("get space: %w", err) | ||
| } | ||
| return cache.Do(s, spc.DerivedIDs().Archive, func(b smartblock.SmartBlock) error { | ||
| archive, ok := b.(collection.Collection) |
There was a problem hiding this comment.
Maybe extract to separate function?
There was a problem hiding this comment.
I have splitted this function onto two separate ones
| return fmt.Errorf("unexpected archive block type: %T", b) | ||
| } | ||
|
|
||
| var multiErr multierror.Error |
There was a problem hiding this comment.
Can be combined
var (
multiErr multierror.Error.
anySucceed bool
)
| if err := multiErr.ErrorOrNil(); err != nil { | ||
| log.Warn("failed to archive", zap.Error(err)) | ||
| } | ||
| if anySucceed { |
There was a problem hiding this comment.
It is seems like unnecessary check, because multiErr.ErrorOrNil() is nil for sure. So can we just return nil instead of lines 243-246?
There was a problem hiding this comment.
The point here is to return nil, if at least one object was processed without error.
If some objects were processed with error, than we should log it.
If all objects were processed with error, than we should return error.
So there is no issue here
| if resultError != nil { | ||
| log.Warn("failed to set objects as favorite", zap.Error(resultError)) | ||
| } | ||
| if anySucceed { |
There was a problem hiding this comment.
The same comment as for isArchive function
There was a problem hiding this comment.
Same situation is here
| Condition: model.BlockContentDataviewFilter_Equal, | ||
| Value: pbtypes.String(spaceId), | ||
| }}}, func(details *types.Struct) { | ||
| for key, v := range details.Fields { |
There was a problem hiding this comment.
Can we rename v to value or something? Because it looks like not consistent naming 🧐
| if err != nil { | ||
| return errors.Join(fmt.Errorf("iterate: %w", err), iter.Close()) | ||
| } | ||
| err = iter.Close() |
There was a problem hiding this comment.
Call "Close" in the defer, because it may cause a connection leak
iter, err := query.Iter(s.componentCtx)
if err != nil {
return fmt.Errorf("find: %w", err)
}
defer func() {
err = iter.Close()
}()
https://linear.app/anytype/issue/GO-3964/provide-the-list-of-relations-on-the-layout-with-date-as-a-value