GO-3737 Fix type reinstall

[KirillSto]

https://linear.app/anytype/issue/GO-3737/after-deleting-the-type-it-is-not-installed

Both archive object and bundle objects installer queried deleted/archived objects using objectstore.Query method.
However this method implicitely adds filters for deleted/archived objects, so query result wasn't always correct.
QueryRaw method should be used in cases like this

[coderabbitai]

Walkthrough

The recent changes streamline several methods in the codebase, enhancing clarity and performance. Key modifications include simplifying method signatures, refining query logic to improve efficiency, and improving documentation on object querying. Overall, these updates focus on maintaining functionality while optimizing the code structure and error handling.

Changes

Files	Change Summary
core/block/editor/archive.go	Simplified method signature by removing unused parameter in updateObjects. Refactored querying to use QueryRaw for improved clarity and performance.
core/block/editor/archive_test.go	Updated mock expectations for objectStore to reflect the new QueryRaw method and its parameter requirements.
core/block/object/objectcreator/installer.go	Removed archived objects query from reinstallBundledObjects. Refactored queryDeletedObjects for clarity and performance; updated query logic and error handling.
pkg/lib/localstore/objectstore/objects.go	Added comment to Query method to clarify implicit filters; advised using QueryRaw for bypassing these filters.

Poem

In burrows deep, we dance with glee,
Code now flows like streams of tea.
With queries quick and signatures pure,
Our codebase blooms, elegant and sure.
Hopping fast, we cheer the change,
A rabbit's joy in every range! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Previous Coverage	47.6% of statements
New Coverage	47.6% of statements
Patch Coverage	87.5% of changed statements (7/8)

---

^{Coverage provided by /~https://github.com/seriousben/go-patch-cover-action}

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9e45a4c and 4d5a5d4.

Files selected for processing (4)

• core/block/editor/archive.go (1 hunks)
• core/block/editor/archive_test.go (1 hunks)
• core/block/object/objectcreator/installer.go (3 hunks)
• pkg/lib/localstore/objectstore/objects.go (1 hunks)

Files skipped from review due to trivial changes (1)

• pkg/lib/localstore/objectstore/objects.go

Additional comments not posted (4)

core/block/editor/archive_test.go (1)

20-20: Mock setup updated to use QueryRaw.

The change from Query to QueryRaw in the mock setup aligns with the updated implementation logic and ensures that the test reflects the current behavior of the Archive component.

core/block/editor/archive.go (2)

75-75: Parameter info replaced with _.

The parameter info is replaced with _ to indicate it is unused, which is a good practice for readability and clarity.

---

81-92: Refactor to use QueryRaw.

The refactoring to use QueryRaw enhances the clarity and potentially the performance of the query logic by using a more streamlined filter construction approach. Ensure that this change is thoroughly tested to confirm it retrieves the correct records.

core/block/object/objectcreator/installer.go (1)

272-299: Refactor queryDeletedObjects to use QueryRaw.

The refactoring of queryDeletedObjects to use QueryRaw improves the efficiency and readability of the query logic. The consolidated conditions using FiltersAnd and FiltersOr make the query more straightforward. Ensure that this change is thoroughly tested to confirm it retrieves the correct records.