GO-3802 Implement add chat #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Coverage provided by /~https://github.com/seriousben/go-patch-cover-action |
deff7
reviewed
Jul 25, 2024
| @@ -57,7 +62,7 @@ func (mw *Middleware) addChat(cctx context.Context, objectId, objId string) (str | |||
| } | |||
|
|
|||
| chatDetails := &types.Struct{Fields: map[string]*types.Value{}} | |||
| chatUniqueKey, err := domain.NewUniqueKey(smartblock.SmartBlockTypeChatObject, objId) | |||
| chatUniqueKey, err := domain.NewUniqueKey(smartblock.SmartBlockTypeChatObject, objectId) | |||
deff7
reviewed
Jul 25, 2024
| return response(pb.RpcObjectCreateResponseError_UNKNOWN_ERROR, "", nil, err) | ||
| } | ||
| if req.WithChat { | ||
| _, err = mw.addChat(cctx, id) |
There was a problem hiding this comment.
move error check close to error assignment
deff7
reviewed
Jul 25, 2024
| uniqueKey := pbtypes.GetString(details, bundle.RelationKeyUniqueKey.String()) | ||
| key, err := domain.UnmarshalUniqueKey(uniqueKey) | ||
| if err != nil { | ||
| return "", nil, fmt.Errorf("unmarshal unique key: %w", err) | ||
| } | ||
|
|
||
| createState := state.NewDocWithUniqueKey("", nil, key).(*state.State) | ||
| details.Fields[bundle.RelationKeyLayout.String()] = pbtypes.String(model.ObjectType_chat.String()) | ||
| details.Fields[bundle.RelationKeyLayout.String()] = pbtypes.String(model.ObjectType_chatDerived.String()) |
There was a problem hiding this comment.
yes, i have understood it like that
deff7
reviewed
Jul 25, 2024
| "github.com/anyproto/anytype-heart/pkg/lib/pb/model" | ||
| "github.com/anyproto/anytype-heart/space/clientspace" | ||
| "github.com/anyproto/anytype-heart/util/pbtypes" | ||
| ) | ||
|
|
||
| func (s *service) createChat(ctx context.Context, space clientspace.Space, details *types.Struct) (string, *types.Struct, error) { | ||
| key, err := domain.NewUniqueKey(smartblock2.SmartBlockTypeChatDerivedObject, bson.NewObjectId().Hex()) |
There was a problem hiding this comment.
derivation makes no sense with random ids
There was a problem hiding this comment.
that was a typo
deff7
approved these changes
Jul 29, 2024
deff7
changed the base branch from
test-ch
to
go-3854-implement-chat-source-and-smartblock
deff7
merged commit 1267236
into
go-3854-implement-chat-source-and-smartblock
5 checks passed
deff7
deleted the
go-3802-chat-add-flag-withchat-to-objectcreate-objectcreateset-and
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?