feat: support loadingRender & rm useless margin #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthrough此次更改为 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Bubble
participant LoadingComponent
User->>Bubble: 触发加载
Bubble->>Bubble: 设置loading为true
Bubble->>Bubble: 判断loadingRender是否存在
alt loadingRender存在
Bubble->>Bubble: 使用loadingRender渲染内容
else loadingRender不存在
Bubble->>LoadingComponent: 渲染默认Loading组件
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
Deploying ant-design-x with
|
| Latest commit: |
461ee5f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://607e8c67.ant-design-x.pages.dev |
| Branch Preview URL: | https://rm-avatar-margin.ant-design-x.pages.dev |
afc163
reviewed
Oct 23, 2024
| if (loading) { | ||
| contentNode = loadingRender ? loadingRender() : <Loading prefixCls={prefixCls} />; | ||
| } else { | ||
| contentNode = mergedContent as React.ReactNode; |
There was a problem hiding this comment.
mergedContent 上面跑完是 ReactNode，但是 TS 自己推断不出来，还会把 object 作为其中之一的类型。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
效果：
Summary by CodeRabbit
新功能
Bubble组件中添加了可选的loadingRender属性，允许在加载状态下自定义渲染内容。bubble-custom.tsx组件，展示了可定制的聊天界面。文档
bubble-custom.md文件，增加了中英文示例，增强了多语言支持。index.en-US.md和index.zh-CN.md中添加了关于loadingRender属性的详细说明和示例代码。样式
BubbleToken接口，移除了bubbleContentMaxWidth属性。