Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DatePicker support variant #46568

Merged
merged 4 commits into from
Dec 21, 2023
Merged

feat: DatePicker support variant #46568

merged 4 commits into from
Dec 21, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 21, 2023

  • feat: DatePicker support variant
  • chore: update snapshot
  • chore: update api table

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English DatePicker support variant prop and new filled variant.
🇨🇳 Chinese DatePicker 支持 variant 属性,并新增 filled 变体

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Visual Regression Report for PR #46568

Target branch: feature (5f395fb)
View Full Report


image name expected actual diff
date-picker-bordered.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
date-picker-bordered.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
date-picker-status.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46568 diff
date-picker-status.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46568 diff
form-validate-static.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46568 diff
form-validate-static.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46568 diff
time-picker-bordered.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
time-picker-bordered.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
time-picker-status.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46568 diff
time-picker-status.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46568 diff

Copy link
Contributor

github-actions bot commented Dec 21, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 329.67 KB (-74 B 🔽)
./dist/antd-with-locales.min.js 375.7 KB (-134 B 🔽)

Copy link

codesandbox-ci bot commented Dec 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 01832ff:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f395fb) 100.00% compared to head (01832ff) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          715       717    +2     
  Lines        12200     12204    +4     
  Branches      3222      3221    -1     
=========================================
+ Hits         12200     12204    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

这两个不会冲突吧

@MadCcc MadCcc merged commit bf70858 into feature Dec 21, 2023
@MadCcc MadCcc deleted the feat/picker-variant branch December 21, 2023 12:43
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@MadCcc
Copy link
Member Author

MadCcc commented Dec 21, 2023

这两个不会冲突吧

先下手为强

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 21, 2023

这两个不会冲突吧

先下手为强

后下手解决冲突!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants