-
-
Notifications
You must be signed in to change notification settings - Fork 51.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: color picker open popup when disabled #44466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zombieJ
approved these changes
Aug 28, 2023
Wxh16144
approved these changes
Aug 28, 2023
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
kiner-tang
approved these changes
Aug 28, 2023
53fed84
to
a738b38
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #44466 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 661 661
Lines 11231 11231
Branches 3042 3042
=========================================
Hits 11231 11231
☔ View full report in Codecov by Sentry. |
This was referenced Sep 28, 2023
This was referenced Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44463
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 53fed84
This pull request enhances the color picker component by fixing a bug, improving the test coverage, and refining the code style. It prevents the
ColorPicker
popup from being toggled when the component is disabled, adds a test case for this scenario, and reorders the imports inColorPicker.tsx
andindex.test.tsx
.🔍 Walkthrough
🤖 Generated by Copilot at 53fed84
Button
component inindex.test.tsx
to use it in the new test case (link)ColorPicker.tsx
as a minor code style improvement (link)