-
-
Notifications
You must be signed in to change notification settings - Fork 51.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TimePicker support rootClassName #44059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44059 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11166 11186 +20
Branches 3024 3029 +5
=========================================
+ Hits 11166 11186 +20
☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Aug 7, 2023
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at ecf1623
Add a new
rootClassName
prop to theTimePicker
component to allow customizing the class name on the root element. Update the TypeScript interface, the test cases, and the documentation in both English and Chinese for this prop.🔍 Walkthrough
🤖 Generated by Copilot at ecf1623
rootClassName
prop toTimePicker
component to allow customizing the class name on the root element (link)TimePicker
component page (link, link)TimePicker
with a custom class name and verifying the snapshot and the class name (link)