Revert "fix(select): Fix Typography component is not centered in the Select component" #43097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #43097 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 648 648
Lines 10957 10957
Branches 2975 2975
=========================================
Hits 10957 10957
☔ View full report in Codecov by Sentry. |
|
demo 还是留一下？看看其他方式解决问题 |
好～ |
…Select component (ant-design#40422)" This reverts commit 2e9d14f.
afc163
approved these changes
Jun 21, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2e9d14f.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #43069
revert #40422
reopen #40421
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at f31fd93
This pull request fixes a bug where the option labels in the select component are not aligned with the input value when using the
labelInValueprop. It removes the unnecessary ellipsis style and the outdated example from the documentation.🔍 Walkthrough
🤖 Generated by Copilot at f31fd93
labelInValueto center option labels in the select component, as it is no longer needed after fixing the alignment bug (link, link, link, link)textEllipsismixin to the direct children of the select dropdown menu, as it causes the option labels to be misaligned with the input value (link, link)