-
-
Notifications
You must be signed in to change notification settings - Fork 51.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ColorPicker): close panel when click clear button #42406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 640 640
Lines 10839 10842 +3
Branches 2944 2945 +1
=========================================
+ Hits 10839 10842 +3
☔ View full report in Codecov by Sentry. |
afc163
reviewed
May 16, 2023
afc163
reviewed
May 16, 2023
e7c8fcb
to
e1f8720
Compare
afc163
approved these changes
May 17, 2023
This was referenced May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
close panel when click clear button
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 8a8b820
Refactored
ColorPicker
component and updated its test case. Added aclearColor
feature that allows users to reset the color and hide the panel.🔍 Walkthrough
🤖 Generated by Copilot at 8a8b820
clearColor
feature toColorPicker
component to allow user to clear color selection (link, link)clearColor
feature inindex.test.tsx
file (link)