Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复form组件在行内布局下展示异常 #41140

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

itkui
Copy link
Contributor

@itkui itkui commented Mar 9, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #41136

💡 Background and solution

image
image

📝 Changelog

Language Changelog
🇺🇸 English fixed Form component layout exceptions when set props layout="inline"
🇨🇳 Chinese 修复 Form 组件 layout="inline" 时组件标题与表单项布局异常换行问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5b78c6a) 99.99% compared to head (6c86816) 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #41140   +/-   ##
========================================
  Coverage   99.99%   100.00%           
========================================
  Files         610       610           
  Lines       10452     10450    -2     
  Branches     2849      2847    -2     
========================================
- Hits        10451     10450    -1     
+ Misses          1         0    -1     
Impacted Files Coverage Δ
components/form/style/index.ts 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Hi @itkui. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@MadCcc
Copy link
Member

MadCcc commented Mar 15, 2023

把 branch 清理一下吧,你把别人的 commit 带进来了

@MadCcc MadCcc reopened this Mar 15, 2023
@afc163 afc163 requested a review from MadCcc March 19, 2023 08:33
@MuxinFeng
Copy link
Contributor

MuxinFeng commented Mar 22, 2023

我本地验证了一下,感觉没啥问题了 ٩(^ᴗ^)۶

@li-jia-nan li-jia-nan merged commit 6a2cad2 into ant-design:master Mar 23, 2023
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
…line" (ant-design#41140)

* fix: 修复form组件在行内布局下展示异常

* fix: 修复form组件在行内布局下展示异常

---------

Co-authored-by: 丁奎 <dingkui02@meituan.com>
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
…line" (ant-design#41140)

* fix: 修复form组件在行内布局下展示异常

* fix: 修复form组件在行内布局下展示异常

---------

Co-authored-by: 丁奎 <dingkui02@meituan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants