Fix deprecated xfreerdp option for winrm targets of EC2 plugin #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apatard
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
molecule logincommand with the Molecule EC2 plugin and a Windows target (winrm connection method) fails with the error:The docs for FreeRDP state that the
cert-tofuCLI option has been deprecated and changed tocert:tofu. This option skips the certificate validation step, which may sense for this use case. See https://manpages.debian.org/unstable/freerdp2-x11/xfreerdp.1.en.html.I tested my fix locally, and changing
/cert-tofuto/cert:tofufixed the issue. I am running molecule on an M4 macbook with FreeRDP version 3.10.2.