This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Handle scoped packages when loading Cljs from node dirs #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could not make pass the linter... isn't a little bit too aggressive with all these types 😄 ? |
arichiardi
force-pushed
the
cljs-scoped-load
branch
4 times, most recently
from
354a414 to
4901d00
Compare
|
Yey! All green! 😉 |
arichiardi
force-pushed
the
cljs-scoped-load
branch
4 times, most recently
from
4e2d4c0 to
23a07ba
Compare
anmonteiro
reviewed
Nov 9, 2017
src/js/lumo.js
Outdated
| @@ -10,36 +10,108 @@ import JSZip from 'jszip'; | |||
| import ArrayStream from './array-stream'; | |||
| import * as util from './util'; | |||
|
|
|||
| function inferNodeModulesClasspathLibs(): string[] { | |||
| const result = []; | |||
| type PackageJsonType = {| | |||
There was a problem hiding this comment.
this is wrong. {| |} refers to a closed object, you want {}
There was a problem hiding this comment.
Oh thanks! Sorry not a flow master I blindly copied your definitions
arichiardi
force-pushed
the
cljs-scoped-load
branch
from
23a07ba to
a70276c
Compare
anmonteiro
reviewed
Nov 9, 2017
src/js/lumo.js
Outdated
| return libPath; | ||
| } | ||
|
|
||
| /* eslint-enable flowtype/no-weak-types */ |
The inferNodeModulesClasspathLibs function becomes recursive so that we can skip directories that don't contain package.json (like scoped package ones).
arichiardi
force-pushed
the
cljs-scoped-load
branch
from
a70276c to
5c23632
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inferNodeModulesClasspathLibs function becomes recursive so that we can
skip directories that don't contain package.json (like scoped package ones).
My Javascript is super poor and it took actually quite a bit to implement this one,
All the changes in the review on styling will be accepted with no barf 😄