This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Add spec completions #279
Merged
Add spec completions #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on the tests for this one |
arichiardi
force-pushed
the
spec-completions
branch
from
43953ca to
4098577
Compare
anmonteiro
reviewed
Sep 26, 2017
src/test/lumo/lumo/repl_tests.cljs
Outdated
| (testing "arbitrary fully qualified keyword" | ||
| (s/def :arbitrary/a-spec string?) | ||
| (is-contains-completion ":arbitrary/" ":arbitrary/a-spec") | ||
| (reset! s/registry-ref {}))))) |
There was a problem hiding this comment.
does it work for aliased nses?
e.g. (s/def ::common/foo string?) and contains a completion for ::common/f
There was a problem hiding this comment.
Gonna add a test for that
arichiardi
force-pushed
the
spec-completions
branch
from
4098577 to
984e3bd
Compare
arichiardi
commented
Sep 26, 2017
| (comp (mapcat keys) (map str)) | ||
| ((juxt :renames :rename-macros :uses :use-macros) (get-namespace cur-ns))))) | ||
| (concat (completion-candidates-for-spec cur-ns) | ||
| (into (completion-candidates-for-ns cur-ns true) |
There was a problem hiding this comment.
I am not entirely sure we need this. It gets spec completions for the current namespace. What do you think?
There was a problem hiding this comment.
might be needed for ::a-spec-style completions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it is, spec completions are working fine.
I need some more time if we want to setup a couple of tests, but it looks like it is already working fine. One thing to think about is the position of the completion candidates. I put the before everything at the moment.
Any comment/feedback will be addressed 😄