Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Ensure that a destroyed effect never runs #59415

Closed
wants to merge 1 commit into from
Closed

fix(core): Ensure that a destroyed effect never runs #59415

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Prior to this change, a scheduled root effect, even if destroyed instantly, would still run at least once.

This commit fixes this.

fixes #59410

@JeanMeche JeanMeche requested a review from alxhub January 7, 2025 20:46
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 7, 2025
@JeanMeche JeanMeche changed the title fix(core): Ensure that a destroyed effect never run. fix(core): Ensure that a destroyed effect never runs Jan 7, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 7, 2025
@JeanMeche
fix(core): Ensure that a destroyed effect never run.
9fb5898 
Prior to this change, a scheduled root effect, even if destroyed instantly, would still run at least once.

This commit fixes this.

fixes angular#59410
@JeanMeche JeanMeche force-pushed the fix/destroyed-effect branch from 56de843 to 9fb5898 Compare January 7, 2025 21:15
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Jan 7, 2025
@ngbot ngbot bot modified the milestone: Backlog Jan 7, 2025
alxhub
alxhub approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

@pullapprove pullapprove bot requested a review from thePunderWoman January 8, 2025 16:00
@thePunderWoman thePunderWoman added the target: patch This PR is targeted for the next patch release label Jan 8, 2025
thePunderWoman
thePunderWoman approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2025
@thePunderWoman
Copy link
Contributor

Caretaker note: this is safe to merge. Failing tests are flakes.

@thePunderWoman thePunderWoman added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 8, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 5c0d688.

The changes were merged into the following branches: main, 19.0.x

thePunderWoman pushed a commit that referenced this pull request Jan 8, 2025
@JeanMeche @thePunderWoman
fix(core): Ensure that a destroyed effect never run. (#59415)
07afce8 
Prior to this change, a scheduled root effect, even if destroyed instantly, would still run at least once.

This commit fixes this.

fixes #59410

PR Close #59415
Debelopercgx
Debelopercgx reviewed Jan 8, 2025
View reviewed changes
Copy link

@Debelopercgx Debelopercgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ok number one looks like a 🏆🥇 winner

kirjs added a commit to kirjs/angular that referenced this pull request Jan 9, 2025
@kirjs
Revert "fix(core): Ensure that a destroyed effect never run. (angul…
f8992cc 
…ar#59415)"

This reverts commit 5c0d688.
kirjs added a commit to kirjs/angular that referenced this pull request Jan 15, 2025
@kirjs
Revert "fix(core): Ensure that a destroyed effect never run. (angul…
3c9fa53 
…ar#59415)"

This reverts commit 5c0d688.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debelopercgx Debelopercgx Debelopercgx left review comments

@eneajaho eneajaho eneajaho left review comments

@alxhub alxhub alxhub approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

EffectRef.destroy has no impact
5 participants
@JeanMeche @thePunderWoman @alxhub @eneajaho @Debelopercgx