feat(core): extend the set of profiler events #59183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
pkozlowski-opensource
added
target: minor
JoostK
reviewed
Dec 13, 2024
pkozlowski-opensource
force-pushed
the
devtools_profiler_events
branch
from
ab7ebe4 to
6629318
Compare
angular-robot
bot
added
area: core
This commit extends the set of events understood by the profiler integrated with the Angular time. The set got extended to account for the recently added functionality and mark entry point to the code execution points. The new set of events can be visualised by the Angular DevTools or other profiler integrations.
pkozlowski-opensource
force-pushed
the
devtools_profiler_events
branch
from
6629318 to
6c4b722
Compare
angular-robot
bot
added
area: core
crisbeto
reviewed
Dec 13, 2024
crisbeto
approved these changes
Dec 14, 2024
| /** | ||
| * Corresponds to the point in time just before application bootstrap. | ||
| */ | ||
| BootstrapApplicationStart, |
There was a problem hiding this comment.
re: #59183 (comment)
Maybe it's worth it to explicitly assign values to these enum fields
TemplateCreateStart = 0,
TemplateCreateEnd = 1,
...Not necessarily a blocker for this PR, but something to think about so that these event identifiers are more explicit instead of relying on implicit values assigned by field ordering
AleksanderBodurri
approved these changes
Dec 17, 2024
pkozlowski-opensource
added
action: merge
|
This PR was merged into the repository by commit 22f191f. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the set of events understood by the profiler integrated with the Angular time. The set got extended to account for the recently added functionality and mark entry point to the code execution points.
The new set of events can be visualised by the Angular DevTools or other profiler integrations.