fix(compiler-cli): consider pre-release versions when detecting feature support #59061
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
added
the
merge: caretaker note
|
Caretaker note: we'll have to patch cl/703005163 together with this change. |
JoostK
approved these changes
Dec 5, 2024
…re support Fixes that the logic which checks whether a feature is supported didn't account for pre-releases. Fixes angular/vscode-ng-language-service#2123.
crisbeto
force-pushed
the
feature-detection-pre-release
branch
from
139c98c to
4046aa6
Compare
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 0dee268. The changes were merged into the following branches: main, 19.0.x |
alxhub
pushed a commit
that referenced
this pull request
Dec 6, 2024
…re support (#59061) Fixes that the logic which checks whether a feature is supported didn't account for pre-releases. Fixes angular/vscode-ng-language-service#2123. PR Close #59061
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the logic which checks whether a feature is supported didn't account for pre-releases.
Fixes angular/vscode-ng-language-service#2123.