Drop usage of the dead rnpm repository #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rnpm` has been replaced by `react-native link`, the `rnpm` package is no longer maintained and is out of sync with the code that actually calls postlink.
|
react-native link does not work in case of android. |
|
How so? |
|
This PR would solve "react-native link" for android: #146 |
|
This PR has nothing to do with Android!!! Other than the fact that the fatal error breaks linking on all platforms. All this PR does is fix the broken |
|
@dantman my comment was about the comment of @codesinghanoop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rnpmhas been replaced byreact-native link, thernpmpackage is no longer maintained and is out of sync with the code that actually calls postlink.