Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make namespace explicit when accessing fmt from fmt::internal #175

Merged
merged 1 commit into from
May 27, 2022
Merged

make namespace explicit when accessing fmt from fmt::internal #175

merged 1 commit into from
May 27, 2022

Conversation

svigerske
Copy link
Contributor

@svigerske svigerske commented May 27, 2022

When compiling with MSVC and /permissive-, we had problems in format.cc.
Members of the anonymous namespace inside fmt were not found when trying to use them from fmt::internal.
With the changes from this PR, we avoid this problem.

@svigerske
Copy link
Contributor Author

As a side note, there are other issues that prevent compilation with /permissive-. Apparently Microsofts own header files are not ready for this so far: https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#windows-header-issues

Adding a

struct IUnknown;

before any

#include <windows.h>

works around these.
As this is not a problem with ampl::mp, I didn't include this here.

@glebbelov glebbelov merged commit e800366 into ampl:master May 27, 2022
@glebbelov
Copy link
Contributor

Merged. The workaround for <windows.h> can be added if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants