You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
invalid.append(("env", "env must be a dict. Got {!r}".format(env)))
returninvalid
wrt the above snippet, is it necessary to enforce dict? This breaks compatibility with other dict-like objects. eg: os.environ returns a dict-like object os._Environ.
Perhaps a check for isinstance(env, collections.Mapping) would allow for more general interface?
The text was updated successfully, but these errors were encountered:
sh/sh.py
Lines 1149 to 1151 in 114e6ee
wrt the above snippet, is it necessary to enforce
dict
? This breaks compatibility with other dict-like objects. eg:os.environ
returns a dict-like objectos._Environ
.Perhaps a check for
isinstance(env, collections.Mapping)
would allow for more general interface?The text was updated successfully, but these errors were encountered: