Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

feat(updateModuleRegistry): include reason for rejection #141

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Mar 27, 2023

Description

when returning rejected modules also include "reasonForRejection"
This will allow any consumer to be able to understand the context for why module was rejected.

Motivation and Context

improve dx

How Has This Been Tested?

unit tests and locally by testing changes within the one-app server.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for Holocron users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Holocron?

@JAdshead JAdshead merged commit a2cd2f8 into main Mar 27, 2023
@JAdshead JAdshead deleted the feat/include-rejected-module-reason branch March 27, 2023 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants