fix(client_core): 🐛 Cap prediction to avoid head and controllers flying off #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like some feedback on the min/max/step of the setting |
|
Ready |
The-personified-devil
approved these changes
Jan 18, 2025
Sometimes it's not so straightforward to identify and sometimes it could be controversial. In this case the changes are unilateral on the client and don't have any consequence on the server side. the setting is on the server side but with our mechanisms of session extrapolation it doesn't become a breaking change. |
zmerp
added a commit
that referenced
this pull request
Jan 18, 2025
…ng off (#2635) * fix(client_core): 🐛 Cap prediction to avoid head and controllers flying off * Add Max prediction setting
Merged
zmerp
added a commit
that referenced
this pull request
Jan 18, 2025
…ng off (#2635) * fix(client_core): 🐛 Cap prediction to avoid head and controllers flying off * Add Max prediction setting
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@omfatimh38 Would you mind explaining to me what you're doing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.