fix: oboe crash by not stopping stream on error #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation the stream will already be closed when there was an error, so my theory is that referencing it again might crash oboe. See https://docs.rs/oboe/0.5.0/oboe/trait.AudioOutputCallback.html#method.on_error_after_close > This will be called when an error occurs on a stream or when the stream is disconnected. The underlying AAudio or OpenSL ES stream will already be stopped AND closed by Oboe. So the underlying stream cannot be referenced. But you can still query most parameters.
|
testing this now |
|
Had no crashes or issues for 2 days of usage with both streamer and client built from the PR, so I think its fine. |
|
Seems straightforward enough for me, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to my PR #2025, where I encountered an audio crash that happened randomly after a couple of minutes or hours of using it(See #2025 (comment)).
I reverted the changes and could confirm the commits in the PR being the issue.
Then I looked further and found out that you shouldn't close the audio stream after an error occurred(see commit message) and was testing this fix in this PR for two days now(~6h of continued usage) without a crash.
I also found out when rebasing, that in a recent commit(005c4c7#diff-662ca07f68bbbec1317ab607076a66fa0daa81ae07df639d3588832f87c509d6R43) you upgraded the oboe crate to 0.6 even though it had a comment/warning on it, and I wonder if it is still relevant.
Couldn't test with the upgraded dependency yet, so I will do that and mark the PR as ready once I am confident everything is stable.