-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: linux views when using modified playspace #2017
Conversation
Another thing we could add as a safety net is to force a |
does this fix issue with slimevr, some games like space engine, recenter in steamvr changing playerspace and breaking view completely? |
the game i tested was subnautica + vr mod, which had a bad case of triggering the issue on the title screen even. recenter and playspace rotate are also fixed. i would think slimevr as well, though i only tested with vive trackers. feel free to test and let me know. |
note that wlx-s will also need to be updated to support rotated playspaces for space drag, you may get weird results with it as of now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns style-wise. I haven't tested myself
I can confirm this fixed the issues I had on Subnautica with the SubmersedVR Mod. It's perfeclty playable with ALVR on linux now. |
Closes #2013
What was changed:
OnPoseUpdated
was wrongvrmath::matMul33
VRApplication_Background
GetTrackingSpace()
which tells us if the universe is seated or standingInitOpenvrClient
andShutdownOpenvrClient
are now state-awareThanks to @Vixea for gathering info & testing