-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove df property and change to_pandas_dataframe to to_pandas #146
Conversation
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 20 20
Lines 1740 1742 +2
=======================================
+ Hits 1737 1739 +2
Misses 3 3
Continue to review full report at Codecov.
|
I'm still thinking about whether Consider this scenario:
We are now out of sync - and the logical type information on the DataTable is not accurate. Should we allow this to happen? Same type of thing could happen if a string column got converted into integers/floats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor sugggestions
def to_pandas(self, copy=False): | ||
"""Retrieves the DataTable's underlying dataframe. | ||
|
||
Note: Do not modify the dataframe unless copy=True has been set to avoid unexpected behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
6828bbc
to
e82cbe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes #116
closes #147
closes #148
.df
propertyto_pandas_dataframe
toto_pandas
.dataframe
replace_none
parameter and don'tfillna
in the DataTables init