Add new test to increase coverage for continuous deployment #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new test that tests the 'destroy' path to delete a given link. Also removed some redundant code that would previously cause the 'destroy' method to throw an error and redirect back if an invalid link was given. Such scenarios are now automatically caught by the ActiveRecord validations since this change (ac607b4) https://trello.com/c/uAx6eKAQ/2276-activate-continuous-deployment-for-local-links-manager
callumknights
force-pushed
the
add-tests-for-CD
branch
from
10a25e6 to
3078972
Compare
thomasleese
reviewed
Jan 5, 2021
callumknights
force-pushed
the
add-tests-for-CD
branch
from
3078972 to
b1cf1fa
Compare
callumknights
force-pushed
the
add-tests-for-CD
branch
from
b1cf1fa to
d846427
Compare
thomasleese
approved these changes
Jan 5, 2021
callumknights
added a commit
to alphagov/govuk-puppet
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new test that tests the 'destroy' path to delete a given link.
Also removed some redundant code that would previously cause the 'destroy'
method to throw an error and redirect back if an invalid link was given.
Such scenarios are now automatically caught by the ActiveRecord validations
since this change (ac607b4)
https://trello.com/c/uAx6eKAQ/2276-activate-continuous-deployment-for-local-links-manager