Allow gov.uk domains to embed pages #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initially added the strict and OWASP recommended 'none' directive based on
the assumption that only side-by-side-browser tool (retired in November 2022)
was preventing us from implementing it.
However some other internal GOV.UK apps use iframes:
- Search Admin
- Best bets (queries)
- External links (recommended-links)
- Content Publisher (Preview feature)
This policy will still ensure sufficient security yet will allow internal
GOV.UK domains to embed pages. It's added to the global base policy because
given the number of frontend application it may be difficult to predict which
frontend app renders the page that we want to iframe. It will reduce the need
to apply a CSP modification in individual apps.
robinjam
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially added the strict and OWASP recommended 'none' directive based on the assumption that only side-by-side-browser tool (retired in November 2022) was preventing us from implementing it.
However some other internal GOV.UK apps use iframes:
This policy will still ensure sufficient security yet will allow internal GOV.UK domains to embed pages. It's added to the global base policy because given the number of frontend application it may be difficult to predict which frontend app renders the page that we want to iframe. It will reduce the need to apply a CSP modification in individual apps.
Trello