Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry for #4113 #4233

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add changelog entry for #4113 #4233

merged 1 commit into from
Sep 20, 2023

Conversation

36degrees
Copy link
Contributor

As part of a Dependabot update for html-validate, we made a change so that the button type attribute is always set (defaulting to submit, which is the same behaviour as if the type attribute is omittted)

Although this isn’t a breaking change, I think it’s worth mentioning in the release notes.

I’ve also updated the PR title to mention the change. This means the fix and the PR title are not identical, as I’ve omitted the html-validate bump here, but I think that’s OK.

As part of a Dependabot update for `html-validate`, we made a change so that the button `type` attribute is always set (defaulting to `submit`, which is the same behaviour as if the `type` attribute is omittted)

Although this isn’t a breaking change, I think it’s worth mentioning in the release notes.

I’ve also updated the PR title to mention the change. This means the fix and the PR title are not identical, as I’ve omitted the `html-validate` bump here, but I think that’s OK.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4233 September 20, 2023 11:27 Inactive
@36degrees 36degrees added this to the v5.0 milestone Sep 20, 2023
@github-actions
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 75.84 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 71.24 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 36.79 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 67.34 KiB
components/accordion/accordion.mjs 21.9 KiB
components/button/button.mjs 4.71 KiB
components/character-count/character-count.mjs 21.64 KiB
components/checkboxes/checkboxes.mjs 5.41 KiB
components/error-summary/error-summary.mjs 6.01 KiB
components/exit-this-page/exit-this-page.mjs 16.6 KiB
components/header/header.mjs 3.34 KiB
components/notification-banner/notification-banner.mjs 4.54 KiB
components/radios/radios.mjs 4.41 KiB
components/skip-link/skip-link.mjs 3.73 KiB
components/tabs/tabs.mjs 9.07 KiB

View stats and visualisations on the review app


Action run for 2464f57

Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Do we need to say it reverses entry f7c8917 to remove button type?

@36degrees
Copy link
Contributor Author

I don't think so – it's linked from the PR if anyone wants to go digging 🕳️

@36degrees 36degrees merged commit 27b82a0 into main Sep 20, 2023
@36degrees 36degrees deleted the 4113-release-note branch September 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants